Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e docker tests fails on lerna publish and other test fixes #9811

Closed
wants to merge 5 commits into from
Closed

Fix e2e docker tests fails on lerna publish and other test fixes #9811

wants to merge 5 commits into from

Conversation

raix
Copy link
Contributor

@raix raix commented Oct 15, 2020

This pull-request attempts to fix the e2e:docker test suite locally

  • Remove local packages from the local package registry (verdaccio) before publishing new packages with the same version should fix [internal] e2e:docker tests fails on lerna publish (works running each test suite separately) #6660
  • Make puppeteer run in the local docker image by using a custom development image (also configured for "development in docker" supported by vs code/github etc.) for better debugging options - puppeteer complained about missing X11lib
  • Prevent yarn e2e:docker to start running if git has untracked changes - this would cause the tests to fail at some point

Not in this pull-request is fixing test issues:

  • Have the local registry started in the development image and expose the port providing better means to debug
  • ModuleScopePlugin is triggered on local package like webpackHotDevClient in smoke tests, will be fixed in Fix refreshOverlayInterop module scope error #9805
  • e2e-installs.sh last test Test when PnP is enabled is broken (at least locally)

@facebook-github-bot
Copy link

Hi @raix!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@raix
Copy link
Contributor Author

raix commented Oct 15, 2020

I just saw new errors on master that I don't have locally yet... I'll close this pull-request until master passes tests, to make sure I don't contribute to more issues in the test setup.

@raix raix closed this Oct 15, 2020
@raix raix reopened this Oct 20, 2020
@raix
Copy link
Contributor Author

raix commented Oct 20, 2020

@iansu This pull-request should fix e2e:docker and puppeteer locally (I guess also add support for github/vs code "development in docker")
Not sure if it's the right time to make this change, I initially closed the pr because tests keep failing on CI for different reasons - seems like we are currently in a bad state?

Would be nice to have all tests passing and block merges to master if they are not. (eg. when making this change and updating the project to webpack 5 I could only see my app working, but not if I was breaking any tests)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

…sts-fails-on-lerna-publish-and-other-test-fixes

* upstream/master:
  Replace deprecated eslint-loader with eslint-webpack-plugin (#9751)
  Upgrade Docusaurus to latest version (#9728)
  fix: resolve new JSX runtime issues (#9788)
  Add AVIF image support (#9611)
@raix raix mentioned this pull request Nov 5, 2020
25 tasks
@raix raix mentioned this pull request Dec 22, 2020
@raix raix added this to the 5.x milestone Nov 27, 2021
@raix raix closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal] e2e:docker tests fails on lerna publish (works running each test suite separately)
3 participants