-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5 fix split chunks issue prod build #11763
Conversation
@iansu not sure why I got the updated package-lock.json, any clues? |
Consider adding maybe a |
This looks good but can you revert the package-lock.json changes? |
Hey @raix, are you still working on this? I could take over otherwise. Apparently, there are merger conflicts and also a request to undo the changes in the package-lock.json file. Thanks. |
would be great to see this in v5.0.2 |
splitChunks: isEnvDevelopment | ||
? undefined | ||
: { | ||
chunks: 'all', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this option can't be used in development mode anymore?
Is it webpack@5 issue, or specific for CRA only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall, it caused issues with fast refresh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a comment about it.
Forked repositories would benefit from this internal knowledge.
Hey there! How is progress with this task? There is a great lack of chunk separation. |
If anyone want to take over would be great, currently out of time 🙏 |
Hi, is there any plan to include this in a future release? As stated by others above, having a single chunk is a pretty major regression... |
+1 we've been blocked from moving to 5.x for almost a year. this is a major blocker for anyone with a significant bundle size. |
So is this fixed? There's a long trail of issues about this but they just get closed with no explanation if this is working. |
My project moved to Vite for what it's worth. |
Credit: @GraxMonzo & @JeremyGrieshop
Reference #11278 (comment)