Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 fix split chunks issue prod build #11763

Closed
wants to merge 2 commits into from
Closed

V5 fix split chunks issue prod build #11763

wants to merge 2 commits into from

Conversation

raix
Copy link
Contributor

@raix raix commented Dec 15, 2021

@raix
Copy link
Contributor Author

raix commented Dec 15, 2021

@iansu not sure why I got the updated package-lock.json, any clues?

@iansu iansu added this to the 5.0.1 milestone Dec 15, 2021
@raix
Copy link
Contributor Author

raix commented Dec 17, 2021

Consider adding maybe a DISABLE_CODESPLITTING=true ref

@iansu
Copy link
Contributor

iansu commented Jan 12, 2022

This looks good but can you revert the package-lock.json changes?

@carlosparreno
Copy link

carlosparreno commented Mar 28, 2022

Hey @raix, are you still working on this? I could take over otherwise. Apparently, there are merger conflicts and also a request to undo the changes in the package-lock.json file.

Thanks.

@keeth
Copy link

keeth commented May 26, 2022

would be great to see this in v5.0.2

Comment on lines +257 to +261
splitChunks: isEnvDevelopment
? undefined
: {
chunks: 'all',
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this option can't be used in development mode anymore?
Is it webpack@5 issue, or specific for CRA only?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall, it caused issues with fast refresh.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a comment about it.
Forked repositories would benefit from this internal knowledge.

@JWo1F
Copy link

JWo1F commented Aug 8, 2022

Hey there! How is progress with this task? There is a great lack of chunk separation.

@raix
Copy link
Contributor Author

raix commented Aug 17, 2022

If anyone want to take over would be great, currently out of time 🙏

@guidupuy
Copy link

guidupuy commented Feb 3, 2023

Hi, is there any plan to include this in a future release? As stated by others above, having a single chunk is a pretty major regression...

@keeth
Copy link

keeth commented Feb 3, 2023

Hi, is there any plan to include this in a future release? As stated by others above, having a single chunk is a pretty major regression...

+1 we've been blocked from moving to 5.x for almost a year. this is a major blocker for anyone with a significant bundle size.

@raix raix closed this by deleting the head repository Apr 3, 2023
@scott-cornwell
Copy link

So is this fixed? There's a long trail of issues about this but they just get closed with no explanation if this is working.

@kellengreen
Copy link

kellengreen commented Nov 8, 2023

create-react-app is deprecated, you'll be better off moving to another build process.

My project moved to Vite for what it's worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.