Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 fix split chunks issue prod build #12213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlosparreno
Copy link

@carlosparreno carlosparreno commented Mar 28, 2022

Ticket: #11963
Credit: @GraxMonzo & @JeremyGrieshop & @raix

There is another PR #11763 with the same fix and some untaken review actions. However, it seems that @raix is inactive in Githbut for a few months and this issue is affecting other teams, so I kindly created this PR to move this fix forward.

@facebook-github-bot
Copy link

Hi @carlosparreno!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@carlosparreno
Copy link
Author

@iansu @mrmckeb, this config change is going to be only for production builds. Do we want this for development environments? So that developers can work on optimization of the chunks?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@JeremyGrieshop
Copy link

@iansu @mrmckeb, this config change is going to be only for production builds. Do we want this for development environments? So that developers can work on optimization of the chunks?

Applying the change to development builds seems to cause problems with the fast refresh loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants