Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "import React" statement from cra-template-typescript #12378

Closed

Conversation

queq1890
Copy link

@queq1890 queq1890 commented May 9, 2022

  • Removed import React from 'react'; statement from cra-template-typescript since the new JSX runtime is introduced in React.js v17 and the current version of create-react-app uses React.js v18.

@facebook-github-bot
Copy link

Hi @queq1890!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@queq1890
Copy link
Author

queq1890 commented May 9, 2022

I just realized this PR is the duplicate of #9907. Please feel free to close my PR if this sort of change is handled in that PR 🙏
I hope there's any update on #9907.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@queq1890 queq1890 closed this May 25, 2022
@queq1890 queq1890 deleted the remove-react-import-from-templates branch May 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants