-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove remaining React imports #9907
base: main
Are you sure you want to change the base?
feat: remove remaining React imports #9907
Conversation
A smoke test has the ESLint error |
Shouldn't this be handled automatically by CC: @yannickcr |
@MichaelDeBoey For For this case I'd say the React import should not be removed from here https://github.com/facebook/create-react-app/pull/9907/files#diff-64c681ba8886069f7e1af46ff0db7eb161244eb14a4a7c780d83eaae6c126cbf since it is still used for |
The current version of TypeScript (4.0.x) doesn't support the new JSX transform (introducing in 4.1). Removing There is code checking the ts version and switch to use new jsx configuration |
@MichaelDeBoey @yannickcr Is it safe to remove those rules from @n3tr There is an issue with TS 4.1 beta support in CRA 4 (#9868) that makes upgrading tricky anyway, and by the time that fix is published TS 4.1 may already be stable. |
TypeScript 4.1 is stable and #9868 has been closed, so this should be ready to merge once the review suggestions are resolved. |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I have an unresolved question:
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
We should still merge this one |
This is ready to review again, but I'd still like to know the plan with the lint config |
Follows up on #9853 and removes remaining React imports, as React 17 is supported and #9734 has been merged.