Change template manifest start_url to dot to make it react-router fri…

[foochu]

The current template has public/manifest.json start_url set to "./index.html". This causes a problem with folks using client side routing since the home screen shortcut points to "https://myapp/index.html" and index.html does not match anything. I'd suggest we change start_url to "." for consistency with the dev server etc. This makes the shortcut point to "https://myapp" instead which is the "standard" form most people use to access these apps. I hope this helps.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[react-scripts-dangerous]

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 02f53e8) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.14-02f53e8.0
# or
yarn add react-scripts-dangerous@1.0.14-02f53e8.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.14-02f53e8.0 folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

[Timer]

@jeffposnick does this PR make sense? Or should this be changed on a per-use basis?

Nothing jumps out at me to make this change if I'm using client-side router.

[jeffposnick]

The service worker configuration we're using assumes that the server at which your web app is deployed will know how to respond to requests for index.html.

While it's a common default setting for most web servers, I don't think we require elsewhere in the project that /index.html and / are treated the same. This PR is a change to the default configuration that would only work if that requirement holds.

Given that manifest.json is something that developers are already likely to modify without ejecting, by customizing the name and branding colors, it's reasonable to expect them to customize their start_url if they use a routing library that requires a different URL scheme.

So I'm in favor of keeping the default start_url as-is.

[Timer]

That makes sense to me, @jeffposnick!

Do you have any objections, @evilchuck?
Could you please adjust this PR to instead add some documentation which makes this proccess more clear?

[foochu]

@Timer No worries. Not sure though if I have much to add to what is covered here https://developer.mozilla.org/en-US/docs/Web/Manifest

[Timer]

Maybe we could add a note at the end of this section of the user guide?

[foochu]

I like that idea @Timer. Added a note

[gaearon]

Personally I'm learning towards assuming the app uses client-side routing rather than index.html. Seems like vast majority of use cases would prefer that.

[foochu]

Thanks @gaearon. Let me know if you want me to reinstate the original fix.

[gaearon]

Let's take this for now, but I'd be open to a future PR that changes defaults to . instead.

[foochu]

No worries. If we change it then can remove these docs as well since it’ll “just work”

[gaearon]

Changed behavior the other way around in #3346.