Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default start_url to . #3346

Merged
merged 3 commits into from
Jan 10, 2018
Merged

Change the default start_url to . #3346

merged 3 commits into from
Jan 10, 2018

Conversation

foochu
Copy link
Contributor

@foochu foochu commented Oct 29, 2017

As per the discussion here #3153 I'm opening a new PR to change the default start_url to .. I'm removing the instructions as well since after this change there is no need to make changes to the default configuration to make client side routing work.

@gaearon gaearon changed the base branch from master to next January 10, 2018 15:40
@gaearon gaearon added this to the 2.0.0 milestone Jan 10, 2018
@gaearon gaearon merged commit 27307ec into facebook:next Jan 10, 2018
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 11, 2018
Timer pushed a commit that referenced this pull request Jan 11, 2018
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 11, 2018
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 13, 2018
gaearon pushed a commit that referenced this pull request Jan 13, 2018
Timer pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants