Initial monorepo configuration #419

ryanyogan · 2016-08-11T04:23:54Z

This PR augments the directory structure to conform to a multi-package "monorepo"

Tree structure changes

create-react-app/
+-- .travis.yml
+-- CHANGELOG.md
+-- CONTRIBUTING.md
+-- LICENSE
+-- PATENTS
+-- README.md
+-- packages/
    +-- create-react-app/  [originally global-cli]
    |   +-- index.js
    |   +-- package.json  [maintaining independent packages]
    +-- react-scripts/  [originally root directory]
    |   +-- bin/
    |   +-- config/
    |   +-- scripts/
    |   +-- template/  [originally in root directory]
    |   +-- .eslintrc.js
    |   +-- .gitignore
    |   +-- package.json [maintaining independent packages]
+-- tasks/
|   +-- e2e.sh
|   +-- release.sh

Status

Given this PR modifies a good portion of the application structure, it may go out of sync quickly.

This PR has been updated to reflect:
master: 7c912b5ffe48eda1c8b0b6f005a117d5764eb0a6
on August 15th, 2016 at 12:15PM PDT

Please ping @ryanyogan if you are reviewing and it is no longer in sync.

How to test

From the root directory run sh tasks/e2e.sh or cd packages/react-scripts && npm run e2e
Manual install of CLI
- cd packages/create-react-app
- npm uninstall create-react-app -g we need to remove your official package temporarily
- npm i . -g <-- this command will install from the local directory
- Note: npm uninstall create-react-app -g when complete, you don't want this test to clash with the official package. Now you can go back to the official npm i create-react-app -g
Further testing
- cd packages/create-react-app && npm i cd packages/react-scripts && npm i && npm run create-react-app test-app
- Test the build process: npm run build
  - You will now have a build folder in the root directory, don't forget to trash it.
- Remember this will create an application named test-app in the packages/react-scripts directory, you will want to trash that once complete. You will also have a node_modules folder in both the packages/create-react-app folder and the packages/react-scripts folder, you will want to delete them with rm -rf node_modules in the respective directory.

Noteable changes / todo's

I made changes that hop around directories in the tasks/e2e.sh file, I am not happy with them I think this file can be improved upon.
Splitting up the paths file into separate modules in addition to making it a tad smarter would help in the future.
I started toying around with Lerna.js in "independant" mode per @hzoo's advice and I found it to be quite nice. Perhaps this would be a nice next step, however I see other issues that should be cleaned up first.

ghost · 2016-08-11T04:24:33Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

ghost · 2016-08-11T04:26:22Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

vjeux · 2016-08-13T01:24:43Z

packages/react-scripts/package.json

@@ -20,6 +20,7 @@
  "files": [
    "bin",
    "config",
+    "PATENTS",


Please do not move the PATENTS file, it must stay at the top of the repo

Fixed, sorry about that

Thanks! No worries, some of the legal related things unfortunately need some special treatment :)

gaearon · 2016-08-13T12:52:41Z

Sorry for the trouble, mind rebasing? Thanks!

ryanyogan · 2016-08-13T21:15:14Z

@gaearon No problem at all

…facebook#403)

ryanyogan · 2016-08-15T19:11:37Z

@gaearon I'm trying to be a good citizen keeping this in sync, given this PR touches so much surface area it is going to get out of sync pretty easily. I rebased again, just ping me if this is going to sit for a while and I will rebase once / if it goes through review. Thanks!

ryanyogan · 2016-08-17T16:49:27Z

Issue #450 will cause an issue with this as well, do you prefer I dump the README.md in the /packages/create-react-app directory and put a more generic one in the root directory?

gaearon · 2016-08-22T12:37:03Z

Sorry, I’ve been jumping between projects lately, and CRA is currently on hold until enough fixes accumulate. I’ll get back to this when I’m ready to cut 0.3.0 (or maybe even get right to 1.0.0).

gaearon · 2016-09-02T15:49:14Z

I would like root README.md to end up in the create-react-app npm on its publish, but keep it in the repo root. Can you figure out how to do this?

gaearon · 2016-09-02T15:49:47Z

I also just merged #257 which changes some things so you’ll need to rebase again, but I’m ready to get this in right after that. Sorry about the back and forth. It’s a massive change and I appreciate the effort.

ryanyogan · 2016-09-02T18:03:20Z

No problem, I'll look into that today and rebase up as well.

Cheers

On Fri, Sep 2, 2016 at 8:50 AM, Dan Abramov notifications@github.com
wrote:

I also just merged #257
#257 which
changes some things so you’ll need to rebase again, but I’m ready to get
this in right after that. Sorry about the back and forth. It’s a massive
change and I appreciate the effort.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACifA2hBe0AOMkz_9qjgAEjVQRqHlvLks5qmEWqgaJpZM4JhyYv
.

ryanyogan · 2016-09-03T20:08:28Z

wow! Lot's of awesome changes! I need to parse through some of this, I may need to take this on tomorrow. I'll try and get it out ASAP.

gaearon · 2016-09-16T22:03:48Z

@ryanyogan This is blocking some future improvements I want to make (since they’ll need new packages). Can you please let me know if you can revisit this? Let us know if you’re too busy and we could ask somebody else to try to get it to a mergeable state. Your help is very much appreciated either way. Thanks!

ryanyogan · 2016-09-17T00:10:41Z

Hi Dan, sorry I have been flying around for some interviews, I can give
this my full attention tomorrow to finish if that is too late by all means
I can push up my broken branch and someone else can take it.

On Fri, Sep 16, 2016 at 5:04 PM, Dan Abramov notifications@github.com
wrote:

@ryanyogan https://github.com/ryanyogan This is blocking some future
improvements I want to make (since they’ll need new packages). Can you
please let me know if you can revisit this? Let us know if you’re too busy
and we could ask somebody else to try to get it to a mergeable state. Your
help is very much appreciated either way. Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACifESY-PxhKfb95v4Nu9q2FngzKw0Rks5qqxJSgaJpZM4JhyYv
.

gaearon · 2016-09-18T19:11:31Z

@ryanyogan If you haven’t had time yet, feel free to push work in progress and I’m sure somebody can pick it up!

ryanyogan · 2016-09-18T22:01:41Z

Will do, sorry, it's been a crazy week.

On Sep 18, 2016 12:11 PM, "Dan Abramov" notifications@github.com wrote:

@ryanyogan https://github.com/ryanyogan If you haven’t had time yet,
feel free to push work in progress and I’m sure somebody can pick it up!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACifG87Ua7vLp-YyHkbH9mEUcRkzqUQks5qrYzxgaJpZM4JhyYv
.

gaearon · 2016-09-19T11:01:43Z

This is now in. Thanks!

ryanyogan mentioned this pull request Aug 11, 2016

Make it a proper multipackage monorepo #403

Closed

ghost added CLA Signed labels Aug 11, 2016

vjeux reviewed Aug 13, 2016
View reviewed changes

ryanyogan force-pushed the monorepo branch from 36e3cf3 to 77de14a Compare August 13, 2016 21:13

ghost added the CLA Signed label Aug 13, 2016

ryanyogan added 10 commits August 15, 2016 14:07

Initial Reconfiguration of application structure (facebook#403)

9f402a5

Removed the build test dir

48b2782

Added in the template folder to package.json (facebook#403)

ebbae98

Updated the contrib documentation (facebook#403)

51bf696

Updated the release.sh to cd into packages/react-scripts (facebook#403)

88fbbcb

Fixed a typo [projects to packages], fail on my end. (facebook#403)

15a5235

Cleaned up the node_modules directory accidently left in for testing, (…

e106c8b

…facebook#403)

Moved PATENTS to correct dir

0b4edd5

Moved PATENTS back to root dir (facebook#403)

533fe73

Remove the snap test from the proper directory (facebook#403)

4fac685

ryanyogan force-pushed the monorepo branch from 77de14a to 4fac685 Compare August 15, 2016 19:07

ghost added the CLA Signed label Aug 15, 2016

gaearon added this to the 0.3.0 milestone Aug 22, 2016

ghost added the CLA Signed label Aug 22, 2016

gaearon modified the milestones: 0.4.0, 0.3.0 Sep 1, 2016

ghost added the CLA Signed label Sep 1, 2016

gaearon added the review-needs-changes label Sep 2, 2016

gaearon mentioned this pull request Sep 2, 2016

refactor(e2e): turn repeated test (build and start) into function #312

Closed

ghost added the CLA Signed label Sep 2, 2016

gaearon modified the milestones: 1.0.0, 0.4.0 Sep 2, 2016

ghost added the CLA Signed label Sep 2, 2016

gaearon modified the milestones: 0.5.0, 1.0.0 Sep 16, 2016

ghost added the CLA Signed label Sep 16, 2016

ghost added the CLA Signed label Sep 17, 2016

This was referenced Sep 17, 2016

Display an overlay for syntax errors #89

Closed

Plugin System #670

Closed

fson mentioned this pull request Sep 18, 2016

Extract Babel configuration to a separate package #674

Closed

ghost added the CLA Signed label Sep 18, 2016

fson mentioned this pull request Sep 19, 2016

Add monorepo configuration with Lerna #678

Closed

6 tasks

gaearon closed this Sep 19, 2016

floriangosse mentioned this pull request Sep 27, 2016

Export react-scripts functionality #781

Closed

lock bot locked and limited conversation to collaborators Jan 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial monorepo configuration #419

Initial monorepo configuration #419

ryanyogan commented Aug 11, 2016 •

edited

Loading

ghost commented Aug 11, 2016

ghost commented Aug 11, 2016

vjeux Aug 13, 2016

ryanyogan Aug 13, 2016

vjeux Aug 13, 2016

gaearon commented Aug 13, 2016

ryanyogan commented Aug 13, 2016

ryanyogan commented Aug 15, 2016

ryanyogan commented Aug 17, 2016

gaearon commented Aug 22, 2016

gaearon commented Sep 2, 2016

gaearon commented Sep 2, 2016

ryanyogan commented Sep 2, 2016

ryanyogan commented Sep 3, 2016

gaearon commented Sep 16, 2016

ryanyogan commented Sep 17, 2016

gaearon commented Sep 18, 2016

ryanyogan commented Sep 18, 2016

gaearon commented Sep 19, 2016

Initial monorepo configuration #419

Initial monorepo configuration #419

Conversation

ryanyogan commented Aug 11, 2016 • edited Loading

This PR augments the directory structure to conform to a multi-package "monorepo"

Tree structure changes

Status

How to test

Noteable changes / todo's

ghost commented Aug 11, 2016

ghost commented Aug 11, 2016

vjeux Aug 13, 2016

Choose a reason for hiding this comment

ryanyogan Aug 13, 2016

Choose a reason for hiding this comment

vjeux Aug 13, 2016

Choose a reason for hiding this comment

gaearon commented Aug 13, 2016

ryanyogan commented Aug 13, 2016

ryanyogan commented Aug 15, 2016

ryanyogan commented Aug 17, 2016

gaearon commented Aug 22, 2016

gaearon commented Sep 2, 2016

gaearon commented Sep 2, 2016

ryanyogan commented Sep 2, 2016

ryanyogan commented Sep 3, 2016

gaearon commented Sep 16, 2016

ryanyogan commented Sep 17, 2016

gaearon commented Sep 18, 2016

ryanyogan commented Sep 18, 2016

gaearon commented Sep 19, 2016

ryanyogan commented Aug 11, 2016 •

edited

Loading