Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monorepo configuration with Lerna #678

Closed
wants to merge 1 commit into from
Closed

Add monorepo configuration with Lerna #678

wants to merge 1 commit into from

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 19, 2016 •
edited
Loading

This adds a monorepo configuration using Lerna.

Lerna improves the workflow of developing with many packages by handling installing and publishing the packages and allows the individual packages in the monorepo to reference each other as if they were installed from npm.

Everything seems to be working, but I haven't tested the end-to-end scripts yet.

Test plan

  • Test npm start
  • Test npm test
  • Test npm run build
  • Test npm run publish
  • Test npm run create-react-app
  • Test npm run e2e

Thanks to @ryanyogan, who started the monorepo work in #419!

@ryanyogan
Copy link

Awesome!! Thanks for stepping in

On Sep 18, 2016 5:10 PM, "Ville Immonen" notifications@github.com wrote:

This adds a monorepo
https://github.com/babel/babel/blob/master/doc/design/monorepo.md
configuration using Lerna https://github.com/lerna/lerna.

Lerna improves the workflow of developing with many packages by handling
installing and publishing the packages and allows the individual packages
in the monorepo to reference each other as if they were installed from npm.

Everything seems to be working, but I haven't tested end-to-end scripts
yet.
Test plan

  • Test npm start
  • Test npm test
  • Test npm run build
  • Test npm run publish
  • Test npm run create-react-app
  • Test npm run e2e

Thanks to @ryanyogan https://github.com/ryanyogan, who started the
monorepo work in #419

#419!

You can view, comment on, or merge this pull request online at:

#678
Commit Summary

  • Set up a monorepo with Lerna

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#678, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACifPe7lLWUqi625ubjRi8mOF0shar1ks5qrdLsgaJpZM4KADyX
.

@ghost ghost added the CLA Signed label Sep 19, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 19, 2016

Awesome, thanks.
e2e will need changes.

@gaearon
Copy link
Contributor

gaearon commented Sep 19, 2016

This is in. Thanks!

@gaearon gaearon closed this Sep 19, 2016
@gaearon gaearon mentioned this pull request Sep 30, 2016
Closed
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fson @ryanyogan @gaearon @facebook-github-bot