Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier console output and template system #461

Closed
wants to merge 6 commits into from

Conversation

MichaelCereda
Copy link

As promised I implemented pretty-cli in the start script.
I created two new files that are used to customize the CLI and to create a personal template.
This approach is compatible with every other console library (ex. blessed) and allows to separate the messages from their visualization in order to be more future proof.

I'm working actively on the project so every opinion/suggestion is welcome.

Thanks.

@MichaelCereda
Copy link
Author

pretty-cli

@SpaceK33z
Copy link
Contributor

webpack-dev-middleware supports a reporter option since version 1.7.0. This might be interesting to use, as it removes the need for adding callbacks for compiler "done", "invalid" etc. events. See the PR for more info.

@MichaelCereda
Copy link
Author

Interesting, I don't know about the change.
I should edit my PR to use those callbacks.
Thank you.
Please let me know if you have any suggestions.

@SpaceK33z
Copy link
Contributor

@MichaelCereda, I don't use CRA myself, so I can't really comment on that. I'm maintaining webpack-dev-server and webpack-dev-middleware though, so if you need any hooks, let me know (preferably in a ticket in the necessary repo).

@ghost ghost added the CLA Signed label Sep 15, 2016
@MichaelCereda
Copy link
Author

Thanks @SpaceK33z, I'll probably text you around next week. I have a couple of ideas in mind.
Have a nice day

@ghost ghost added the CLA Signed label Sep 16, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2016

Thanks for the pull request.
Sorry it took so long to review.

I’ve been blocked on some changes to packaging (#678), and those were important to get in because they opened the door to other features I cared about (#744).

I am closing this for roughly the same reasons as #499 (comment). And I’m sorry I didn’t do a good job of communicating it early. Wasted effort is very frustrating so I apologize for that.

In short, I have moved the Webpack message cleanup into a helper in our utilities package. At this point I’d rather avoid an extra opinionated dependency for users after ejecting. There are some things in the API that I would rather avoid as well, such as dynamic “method injection”. This feels like an over-abstraction for such a simple use case as logging output, and I don’t see the need for it at this moment.

Again, I’m sorry for wasting your time.

@gaearon gaearon closed this Sep 30, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants