Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated package reference #7170

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Update deprecated package reference #7170

merged 2 commits into from
Jun 5, 2019

Conversation

bnewcomb
Copy link
Contributor

@bnewcomb bnewcomb commented Jun 5, 2019

Installing the latest react-testing-library will cause issues because it is now deprecated and will throw react-testing-library has moved to @testing-library/react when imported. more info. This updates the document to use the new scoped package.

Installing the latest react-testing-library will cause issues because it is now deprecated and will throw `react-testing-library has moved to @testing-library/react` when imported. [more info](testing-library/dom-testing-library#260). This updates the document to use the new scoped package.
@bnewcomb bnewcomb requested review from amyrlam and iansu as code owners June 5, 2019 07:11
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

docusaurus/docs/running-tests.md Outdated Show resolved Hide resolved
@iansu iansu added this to the 3.0.2 milestone Jun 5, 2019
@iansu iansu merged commit f05465e into facebook:master Jun 5, 2019
@iansu
Copy link
Contributor

iansu commented Jun 5, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Jun 11, 2019
@bnewcomb bnewcomb deleted the patch-1 branch May 26, 2020 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants