Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable .eslintignore again #7562

Merged
merged 3 commits into from
Sep 24, 2019
Merged

enable .eslintignore again #7562

merged 3 commits into from
Sep 24, 2019

Conversation

igtm
Copy link
Contributor

@igtm igtm commented Aug 19, 2019

This line of code has been added by this PR.

But I cannot understand why react-script doesn't support the essential config file of eslint.

I'd say that it should be needed for some cases such as ignoring generated files or something like that.

This topic about .eslintignore has been discussed as follows

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@igtm
Copy link
Contributor Author

igtm commented Aug 19, 2019

I signed up just now!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@silverwind
Copy link

Maybe only enable it when EXTEND_ESLINT=true?

@nickserv
Copy link
Contributor

nickserv commented Sep 13, 2019

I'd love to have this merged. It's frustrating that trying to use a strict ESLint config on my own code causes unnecessary warnings on generated files that shouldn't be modified, and it prevents me from using EXTEND_ESLINT=true.

@ianschmitz ianschmitz closed this Sep 13, 2019
@ianschmitz ianschmitz reopened this Sep 13, 2019
@ianschmitz
Copy link
Contributor

@mrmckeb any concerns with this one having done the eslint config work?

@ianschmitz ianschmitz added this to the 3.x milestone Sep 13, 2019
@ianschmitz
Copy link
Contributor

Maybe only enable it when EXTEND_ESLINT=true?

That could be a good idea. I guess the question is should we support this file even if the user isn't modifying our OOTB lint config?

@nickserv
Copy link
Contributor

I think it would be more consistent to only respect the ESLint ignore if EXTEND_ESLINT=true, since without this variable an ESLint config is ignored, and ESLint ignores often accompany ESLint configs.

@ianschmitz ianschmitz closed this Sep 14, 2019
@ianschmitz ianschmitz reopened this Sep 14, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 18, 2019

@igtm We think we can get this into our 3.2 release, but it needs to be behind the flag EXTEND_ESLINT=true for now.

Can you make that change?

@mrmckeb mrmckeb self-assigned this Sep 18, 2019
@igtm
Copy link
Contributor Author

igtm commented Sep 23, 2019

I'm sorry for the late reply.
I changed the code so that it can be enabled only when EXTEND_ESLINT is true

@ianschmitz ianschmitz modified the milestones: 3.x, 3.2 Sep 23, 2019
@mrmckeb mrmckeb merged commit 6f5221c into facebook:master Sep 24, 2019
@igtm igtm deleted the fix/eslintignore branch September 24, 2019 12:00
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
@ianschmitz ianschmitz modified the milestones: 3.2, 3.1.3 Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants