Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable .eslintignore again #7562

Merged
merged 3 commits into from
Sep 24, 2019
Merged

enable .eslintignore again #7562

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e89d5d
enable .eslintignore again
igtm Aug 19, 2019
245729e
Merge remote-tracking branch 'upstream/master' into fix/eslintignore
igtm Sep 23, 2019
38e2d78
[add] enable .eslintignore file only if EXTEND_ESLINT === 'true'
igtm Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ module.exports = function(webpackEnv) {
eslintPath: require.resolve('eslint'),
resolvePluginsRelativeTo: __dirname,
// @remove-on-eject-begin
ignore: process.env.EXTEND_ESLINT === 'true',
baseConfig: (() => {
const eslintCli = new eslint.CLIEngine();
let eslintConfig;
Expand All @@ -360,7 +361,6 @@ module.exports = function(webpackEnv) {
};
}
})(),
ignore: false,
useEslintrc: false,
// @remove-on-eject-end
},
Expand Down