Added Rails link to User Guide #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Sorry for long review. |
…ook#927) * Enable babel parameters/destructuring for all versions of Node * Add more descriptive comment explaining plugin use
* Update dependencies * Use published version of eslint-config-react-app for development We dogfood on our eslint-config-react-app by using it as our ESLint config, but installing it from the local folder causes problems when its peerDependencies are updated, because npm won't update it unless the version number changes. Use the published version for dogfooding so it can be installed from npm.
Enable no-webpack-loader-syntax rule in eslint-config-react-app.
This reverts commit 1ef6ea5.
gh-pages supports https. It's important for prominent help files to encourage best practices.
Running `create-react-app` in a Docker container causes an unhandled rejection error in nodejs > 6.5 because the `opn` module tries to open a web browser in a system that doesn't have one. I figured this error could be safely ignored.
* Always build before deploying to gh-pages * Add line to gh-pages deploy docs about CNAME file * Remove spaces in npm run command for Windows * Grammar nit * Minor tweaks
Upgrade `babel-loader` and remove the cache directory configuration that was added in facebook#620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
…#1148) Use a 'BROWSER' environment variable with npm start to specify which browser to open. if the value of 'BROWSER' is not valid executable file, don't open any browser.
* Add "Changing the Page Title" to User Guide * Add link to main README
…nd Errors" (facebook#1260) * Adds note on how to resolve file or directory not found errors for heroku deployments * Style tweaks
…k#1264) Browser launch can still be suppressed using BROWSER=none
…ook#1270) * facebookgh-1269: Enabling nested folder paths for project name * facebookgh-1269: Added "fs-extra" and removed "path-exists" * facebookgh-1269: Added e2e test cases to verify nested folder names
There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering.
Array.forEach is passed the following parameters:
currentValue
The current element being processed in the array.
index
The index of the current element being processed in the array.
array
- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
console.log takes multiple arguments. We only want to print the first one, the actually message.
* Document Flow support Projects created by Create React App use the `babel-preset-react` which includes Flow babel plugins which introduces new syntax. This is important for users to know as it causes what used to be syntax errors to be silently suppressed because they're valid type annotations in Flow. For example if a user accidentally has `[foo: 'bar']`, Babel will silently convert it to `[foo]`. * Make it a bit clearer
|
Woops. I'm fairly new to OSS so really sorry about this.. Maybe I should just delete this PR and make a new one with my changes? I thought rebasing master into my own fork was the way to go but this mess cannot be merged i guess? |
|
Better to create a new PR. Not sure what happened 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #838