Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast refresh is enabled if FAST_REFRESH environment variable is not defined #9918

Closed
wants to merge 2 commits into from

Conversation

martinfrancois
Copy link

As pointed out here: #9913 (comment)

The comment in the code clearly states // which is why it's disabled by default. suggesting react-refresh should be disabled by default.
But if the environment variable FAST_REFRESH is not set at all, the condition process.env.FAST_REFRESH !== 'false' evaluates to true (as undefined !== 'false'), enabling react-refresh.

@facebook-github-bot
Copy link

Hi @martinfrancois!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@n3tr
Copy link
Contributor

n3tr commented Oct 27, 2020

@martinfrancois I think Fast Refresh is enabled by default per #9350.

Maybe @iansu forgot to update the comment.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@martinfrancois
Copy link
Author

@n3tr true! In this case, let's change the comment, thanks!

@martinfrancois
Copy link
Author

@petetnt thanks for approving! Will this PR be merged at one point?

@stale
Copy link

stale bot commented Dec 19, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 19, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants