No option --skip-image-compression

[Balandat]

🐛 Bug Report

Docusaurus seems to have lost its --skip-image-compression option.

Filing this as a bug report because

1. the docs talk still show this option: https://github.com/facebook/Docusaurus/blob/master/docs/api-commands.md#docusaurus-build
2. not being able to do this messes up an svg that I'm using

Have you read the Contributing Guidelines on issues?

Yep

To Reproduce

yarn build --skip-image-compression

My package.json:

{
  "scripts": {
    "examples": "docusaurus-examples",
    "start": "docusaurus-start",
    "build": "docusaurus-build",
    "publish-gh-pages": "docusaurus-publish",
    "write-translations": "docusaurus-write-translations",
    "version": "docusaurus-version",
    "rename-version": "docusaurus-rename-version"
  },
  "devDependencies": {
    "docusaurus": "^1.9.0"
  }
}

Expected behavior

Image compression steps should be skipped

Actual Behavior

Errors out: error: unknown option --skip-image-compression'`

[JoelMarcey]

hmmm... seems to be there.

packages/docusaurus-1.x/lib/server/generate.js:40:  commander.option('--skip-image-compression').parse(process.argv);

Looking at https://docusaurus.io/docs/en/commands#using-arguments

What happens if you try:

yarn run build --skip-image-compression

[Balandat]

The same, I had tried that. The option doesn't even seem to be recognized:

yarn run build --help
Using globally installed version of Yarn
yarn run v1.12.1
warning package.json: No license field
$ docusaurus-build --help
Usage: docusaurus-build [options]

Options:
  --skip-next-release
  -h, --help           output usage information

[ahmadalfy]

I created that feature and I can check why it stopped working. I am also interested in knowing why the compressor corrupt the photo, that shouldn't happen

[yangshun]

Thanks @ahmadalfy! It was nice meeting you in person today as well 😄

[Balandat]

@ahmadalfy I now think the compressor did not corrupt the image. I ran into a really weird thing when just copying the svg to a new file messed up the rendering. There must be something really fishy going on with that image.

[endiliey]

I now think the compressor did not corrupt the image. I ran into a really weird thing when just copying the svg to a new file messed up the rendering. There must be something really fishy going on with that image.

@Balandat do you want to share the image here ? Maybe someone might be able to check that image/ give some suggestion on that.

Nevertheless, it's still true that this --skip-image-compression suddenly went missing. Thanks for reporting 😉

[endiliey]

I think the skipNextRelease PR broke this.
#1292

Basically all of our command went missing.

[aeneasr]

Can this please be released? For me, all SVGs are broken due to minification and I'm not able to disable it.

[endiliey]

1.10.0

[aeneasr]

Oh yeah and here are the two SVGs in case someone want's to see what's going on:

• source
• minified

edit:// thank you @endiliey

[endiliey]

Let me know if it doesn't work for you. I sent that fix. Need to know if it's working

[aeneasr]

Yup, works fine!