Skip to content

Commit

Permalink
Fix image corruption (#128)
Browse files Browse the repository at this point in the history
Summary:
Docusaurus runs image compression under the hood, which messes up the botorch logo lockup svg.

It used to be possible to skip this compression but apparently b/c of a bug in docusaurus that's not possible on recent versions: facebook/docusaurus#1427

We'll have to hack this until that is fixed.
Pull Request resolved: #128

Reviewed By: ldworkin

Differential Revision: D15148030

Pulled By: Balandat

fbshipit-source-id: 619eecba6c28c105499a7c9a0368977026736f2b
  • Loading branch information
Balandat authored and facebook-github-bot committed Apr 30, 2019
1 parent be20a5a commit d60ea1c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions scripts/build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ if [[ $BUILD_STATIC == true ]]; then
echo "Building static site"
echo "-----------------------------------"
yarn build
# hack to correct logo since docusaurus messes it up during build
# This needs to be done until https://github.com/facebook/Docusaurus/issues/1427 is fixed
cp static/img/botorch_logo_lockup_white.svg build/botorch/img/botorch_logo_lockup_white.svg
else
echo "-----------------------------------"
echo "Starting local server"
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"rename-version": "docusaurus-rename-version"
},
"devDependencies": {
"docusaurus": "^1.7.2"
"docusaurus": "^1.9.0"
}
}

0 comments on commit d60ea1c

Please sign in to comment.