-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme-algolia): useDocusaurusContext import error #10382
Conversation
Please disregard the commit history that shows 2022. I used the same forked repository, which is displaying the commit history from 2 years ago. |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
useDocusaurusContext
Import FixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks😅
Our website build succeeds because we build using our own codebase which has the TS source; the E2E tests pass because they don't use the Algolia theme!
@anaclumos Have you tried with this fix locally to see if the website builds successfully? Just afraid there may be similar errors. |
Yes. I overrode the dependencies using npm workspaces with the following modifications. It successfully compiles. Here is a PoC: anaclumos/extracranial@02374fe Seems like Docusaurus 3.5 moved/repackaged some internal libraries? I had to make other fixes that I swizzled before. |
Yeah we did, which was the PR that broke this: #10316 |
proper fix released in v3.5.1 Let me know if this works well for you |
For when facebook/docusaurus#10382 ships in a patch release.
Motivation
After updating to Docusaurus v3.5, I got:
Which I diagnosed:
Which can be fixed with: