fix(core): algolia context import #10384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Josh-Cena
approved these changes
Aug 9, 2024
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +276 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
|
Report too large to display inline |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
Note I also need to fix the Cheerio version because they just released 1.0.0 which bums node vs the RC, while we support Node 18.0 |
|
Maybe it's time to go to Docusaurus v4, or start collecting possible BCs for v4, just so we can go to Node 20+ :) |
slorber
changed the title
Yes I've gathered many little braking changes I'd like to do for v4 as code TODOs and notes I was waiting for React 19 stable (and eventually React Router v7) but it's not so close to being released apparently so it's probably not worth waiting, we can upgrade to v19 for Docusaurus v5. |
michaelklishin
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Aug 11, 2024
3.5.1 contains an Algolia search plugin fix [1]. While at it, fix a few warnings emitted on/by the 3.5.x series. 1. facebook/docusaurus#10384
This was referenced Aug 31, 2024
Open
This was referenced Aug 31, 2024
This was referenced Sep 1, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
This was referenced Oct 20, 2024
Merged
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
v3.5 is broken due to a bad import after refactoring.
#10382 probably fixes it but it's still not the public import for this API, so let's fix it properly.
Test Plan
CI
Test links
https://deploy-preview-10384--docusaurus-2.netlify.app/
Related issues/PRs
Refactor that broke the import: #10316