Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): fix Spanish translation for "breadcrumbs" #10413

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(translations): fix Spanish translation for "breadcrumbs" #10413

merged 1 commit into from
Aug 19, 2024

Conversation

TheMineWay
Copy link
Contributor

@TheMineWay TheMineWay commented Aug 17, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Improve spanish translations to keep the software understandable for all.
The previous translation was correct but it was too literal (spanish people would not understand what "Migas de pan" is in a website. Even developers). By using "Rastro de navegación" people would understand better the concept.
This does not fix any issue nor bug.

Test Plan

Spanish speakers can verify that the new translation is better to understand.

Test links

Deploy preview: https://deploy-preview-10413--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @TheMineWay!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Aug 17, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ae1ba37
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66c085abb6f5fe00089ca912
😎 Deploy Preview https://deploy-preview-10413--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟢 91 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 58 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 70 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 17, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -49,7 +49,7 @@
"theme.contentVisibility.unlistedBanner.title": "Página sin clasificar",
"theme.docs.DocCard.categoryDescription.plurals": "1 artículo|{count} artículos",
"theme.docs.breadcrumbs.home": "Página de Inicio",
"theme.docs.breadcrumbs.navAriaLabel": "Migas de pan",
"theme.docs.breadcrumbs.navAriaLabel": "Rastro de navegación",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure?

This has been submitted recently in #10360 and I double checked and apparently Migas de pan is more common than Rastro de navegación (but I'm not a Spanish native speaker so can't be 100% sure)

Can you say something @sergioalmela ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native speaker "Migas de pan" sounds a little bit confusing (and I personally never heard it anywhere else that in English. Simply by asking some people I've seen that nobody knew what "migas de pan" was). "Rastro de navegación" or other terms might not be as "common" but it is understandable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on that, unfortunately, and will let Spanish users settle.

The only thing I see is that Google uses another term: Ruta de navegación/exploración

https://developers.google.com/search/docs/appearance/structured-data/breadcrumb?hl=es

@slorber
Copy link
Collaborator

slorber commented Aug 19, 2024

Thanks

Can you back your claim with a link to an authoritative source (like Google?) favoring one term over the other?

Because from my perspective the tools I can use disagree with you

CleanShot 2024-08-19 at 14 21 09@2x

@TheMineWay
Copy link
Contributor Author

Thanks

Can you back your claim with a link to an authoritative source (like Google?) favoring one term over the other?

Because from my perspective the tools I can use disagree with you

CleanShot 2024-08-19 at 14 21 09@2x

I think this answer shows exacly what the reason of my proposal was:

I prefer to keep it understandable, because Breadcrumbs is a very standarized concept, but in Spanish almost anyone knows what "migas the pan" is (I never seen it in any software btw).

imagen

@sergioalmela
Copy link
Contributor

Maybe I'm very used to say migas de pan because we said that in my company, but to be honest maybe what you said is more understandable to non-technical users.

@slorber
Copy link
Collaborator

slorber commented Aug 19, 2024

Thanks @sergioalmela , so you agree merging this PR would be fine?

@sergioalmela
Copy link
Contributor

Thanks @sergioalmela , so you agree merging this PR would be fine?

Yes

@slorber slorber changed the title fix: I18n improvements - breadcrumb translation was too literal fix(translations): fix Spanish translation for "breadcrumbs" Aug 19, 2024
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 19, 2024
@slorber
Copy link
Collaborator

slorber commented Aug 19, 2024

Thanks 👍

@slorber slorber merged commit 0b640ca into facebook:main Aug 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants