-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translations): fix Spanish translation for "breadcrumbs" #10413
Conversation
Hi @TheMineWay! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@@ -49,7 +49,7 @@ | |||
"theme.contentVisibility.unlistedBanner.title": "Página sin clasificar", | |||
"theme.docs.DocCard.categoryDescription.plurals": "1 artículo|{count} artículos", | |||
"theme.docs.breadcrumbs.home": "Página de Inicio", | |||
"theme.docs.breadcrumbs.navAriaLabel": "Migas de pan", | |||
"theme.docs.breadcrumbs.navAriaLabel": "Rastro de navegación", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure?
This has been submitted recently in #10360 and I double checked and apparently Migas de pan
is more common than Rastro de navegación
(but I'm not a Spanish native speaker so can't be 100% sure)
Can you say something @sergioalmela ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a native speaker "Migas de pan" sounds a little bit confusing (and I personally never heard it anywhere else that in English. Simply by asking some people I've seen that nobody knew what "migas de pan" was). "Rastro de navegación" or other terms might not be as "common" but it is understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on that, unfortunately, and will let Spanish users settle.
The only thing I see is that Google uses another term: Ruta de navegación/exploración
https://developers.google.com/search/docs/appearance/structured-data/breadcrumb?hl=es
I think this answer shows exacly what the reason of my proposal was: I prefer to keep it understandable, because Breadcrumbs is a very standarized concept, but in Spanish almost anyone knows what "migas the pan" is (I never seen it in any software btw). |
Maybe I'm very used to say migas de pan because we said that in my company, but to be honest maybe what you said is more understandable to non-technical users. |
Thanks @sergioalmela , so you agree merging this PR would be fine? |
Yes |
Thanks 👍 |
Pre-flight checklist
Motivation
Improve spanish translations to keep the software understandable for all.
The previous translation was correct but it was too literal (spanish people would not understand what "Migas de pan" is in a website. Even developers). By using "Rastro de navegación" people would understand better the concept.
This does not fix any issue nor bug.
Test Plan
Spanish speakers can verify that the new translation is better to understand.
Test links
Deploy preview: https://deploy-preview-10413--docusaurus-2.netlify.app/
Related issues/PRs