refactor(v2): enhance CLI experience #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <me@rdil.rocks>
|
Deploy preview for docusaurus-2 ready! Built with commit d196aac |
yangshun
suggested changes
Apr 8, 2020
| @@ -39,15 +39,15 @@ cli | |||
| .description('Build website') | |||
| .option( | |||
| '--bundle-analyzer', | |||
| 'Visualize size of webpack output files with an interactive zoomable treemap (default = false)', | |||
| 'Visualize size of webpack output files with an interactive zoomable treemap (default: disabled)', | |||
There was a problem hiding this comment.
I think we should retain the boolean values here as it's much easier for the user to know what value to use. Could you change them back?
| : // GitHub enterprise hosting. | ||
| `https://${githubHost}/pages/${organizationName}/${projectName}`; | ||
| shell.echo(`Website is live at: ${websiteURL}`); | ||
| let websiteURL = ''; |
There was a problem hiding this comment.
I'm going to revert this section since it's not a trivial change. You can submit a new PR just for these changes.
yangshun
added
the
pr: polish
yangshun
changed the title
yangshun
added a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
Motivation
The CLI had a few problems with grammar mistakes, some inconsistancies, and just some other stuff in general that I made better based on my trials of d2.
Have you read the Contributing Guidelines on pull requests?
I have contributed before, yet I should have read them.
Also I ran prettier on the docs (
yarn prettier-docs) because my IDE (WebStorm) was complaining about it.Test Plan
I tried out the new CLI and I think its better.
Related PRs
None.
By opening this PR I understand and confirm that the work submitted is my own and have read and agreed to the Facebook contributor license agreement.