-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): properly link top-level github pages sites in deploy command #2558
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 8553aaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a test plan to convince us that this doesn't break existing behavior.
Removing our PR template is not cool.
Sorry @yangshun, fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
Motivation
Found this issue while trying to make a site, so I fixed it
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
I tested it by creating a docusaurus site and I verified that the correct URLs are logged.
Related PRs
This was in #2556 but @yangshun reverted it