Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix broken build when swizzled NotFound component exist #2854

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 1, 2020

Motivation

Finally resolve #2229

I fixed the bug causing issue error in the react-loadable-ssr-addon lib, although I did not establish the exact reasons, but it doesn’t matter, the main thing is that the website building is now successful.

Actually, because we use the caret versions range, the react-loadable-ssr-addon dependency is already updated, but this PR explicitly bumps a new version to formally close the issue.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Checkout to this branch
  2. Inside website-build-fail dir, run yarn build
  3. Make sure the website was built successfully

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jun 1, 2020
@lex111 lex111 requested a review from yangshun as a code owner June 1, 2020 10:10
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 4ad9b58

https://deploy-preview-2854--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deserve a medal 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] 404.html routePath does not include siteConfig.baseUrl
4 participants