🐛 Add all chunks from stats object

[lex111]

Summary

In my project, I encountered an error (see below), in the end I found out that not all chunks are added to manifest, I tried to fix it.

Why

In my code, I ran into a problem when the chunk is used, but was not defined in the assets property, which is why I got the following error (from getBundles).

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Array.reduce (<anonymous>)TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Array.reduce (<anonymous>)

As a rule, chunk.ids contains only one element - this is chunk.id, but there are cases when there may be several ids, and it seems to me that we should take this fact into account.

@themgoncalves honestly, I don’t know for sure if this solution is right, but it solved my problem. I would be grateful if you could help me improve this change.

Checklist

• Your code builds clean without any errors or warnings
• You are using approved terminology
• You have added unit tests, if apply.

[lex111]

Hi @themgoncalves, any thoughts about this PR?

[themgoncalves]

Hi @lex111,

Thanks for your contribution, I will be debugging the code and making sure that we got it all covered, but for that, I need to have more infos so I can a test environment for that.

Do you mind to share a code demo that runs the issue you reported?

[lex111]

We use your lib in Docusaurus, you probably remember this project.

Reproducible demo you can find here https://github.com/facebook/docusaurus/tree/repro-2244/website-build-fail

When you try to build that site by running the yarn build command, you get the error that I indicated in the issue.

This happens when the user overrides the NotFound component (see https://v2.docusaurus.io/docs/using-themes/#swizzling-theme-components). If you delete this file, then there will be no fatal errors when building the site.

I don’t understand why this is happening, I just found out that it is due to react-loadable-ssr-addon
So I will be very glad if you can help with this strange error. I hope you have enough information for debugging?

[themgoncalves]

Yes, this is enough information. I’ll be getting back to this topic tomorrow.

Thanks for sharing such detailed infos.

[themgoncalves]

Code wise and functionality looks good.
Couldn't find any possible issues that this PR could introduce, so we're good to go.

[lex111]

@themgoncalves thank you! Although I do not understand why and how more elements can appear in chunks array. But in any case, this PR should not bring breaking changes. Could you please release a new version?

[themgoncalves]

@lex111 v0.2.1 was released: https://www.npmjs.com/package/react-loadable-ssr-addon

[themgoncalves]

@lex111 As precaution measure I just release another patch with a few packages downgrade, as it was showing flaky behaviour which concerns me.

[lex111]

@themgoncalves I got you, so I will use v0.2.2 then.