Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): broken links detector: ignore existing folders #3107

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 23, 2020

Motivation

In the broken links detection code, we try to see if a link match an existing fs file in the build folder. We should not consider folders in this algo, only files, as this part of the code is to avoid reporting errors when user link to a static file (broken SPA paths is handled in a different way without reading the FS)

@slorber slorber requested a review from yangshun as a code owner July 23, 2020 17:14
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 23, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit c84f3f0

https://deploy-preview-3107--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 23, 2020
@slorber slorber merged commit 6aec331 into master Jul 24, 2020
@yangshun yangshun deleted the slorber/broken-links-only-consider-files branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants