Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): broken links detector: ignore existing folders #3107

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix(v2): broken links detector: ignore existing folders #3107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/docusaurus/src/server/brokenLinks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,17 @@ async function filterExistingFileLinks({
allCollectedLinks: Record<string, string[]>;
}): Promise<Record<string, string[]>> {
// not easy to make this async :'(
function linkFileDoesNotExist(link: string): boolean {
function linkFileExists(link: string): boolean {
const filePath = `${outDir}/${removePrefix(link, baseUrl)}`;
const exists = fs.existsSync(filePath);
return !exists;
try {
return fs.statSync(filePath).isFile(); // only consider files
} catch (e) {
return false;
}
}

return mapValues(allCollectedLinks, (links) => {
return links.filter(linkFileDoesNotExist);
return links.filter((link) => !linkFileExists(link));
});
}

Expand Down