Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): run Jest tests on Windows workflow #3481

Closed
wants to merge 1 commit into from

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Sep 24, 2020

Motivation

Currently many Jest tests fails on Windows due to paths issues.

This PR adds additional test run step to Windows workflow (and it is expected to fail).

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 24, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 3c4ddfe

https://deploy-preview-3481--docusaurus-2.netlify.app

@Simek
Copy link
Contributor Author

Simek commented Sep 24, 2020

@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

oh, that's unfortunate, didn't know that tests weren't passing on Windows, and it seems a bit of work to get this fixed.

Unfortunately, I don't even have a Windows computer here 😅 not sure what I can do. I know we had windows related fixes recently using path.posix() method and we also have our own posixPath() fn in @docusaurus/utils

For now, we'd better keep this PR as a draft unless someone is willing to actively work on this issue.

@slorber slorber marked this pull request as draft September 28, 2020 14:21
@skrmain skrmain mentioned this pull request Oct 5, 2020
8 tasks
@slorber
Copy link
Collaborator

slorber commented Oct 5, 2020

Closing for #3540

@slorber
Copy link
Collaborator

slorber commented Dec 28, 2020

#3959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Jest tests cross-platform (fix Jest tests on Windows)
4 participants