-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): fix windows Jest tests #3959
Conversation
- add the posixPath in writeRedirectsFiles.ts
add posixPath in test and index
- add the window test configuration in nodejs-windows.yml
# Conflicts: # .github/workflows/nodejs-windows.yml # packages/docusaurus-plugin-client-redirects/src/writeRedirectFiles.ts
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: fb44971 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fea24de56ea940007bdc2ce 😎 Browse the preview: https://deploy-preview-3959--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3959--docusaurus-2.netlify.app/classic/ |
Size Change: +8 B (0%) Total Size: 155 kB ℹ️ View Unchanged
|
Motivation
Jest tests should run on Windows CI
Currently they do not run, and there are some failures related to win32 vs posix paths
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
CI + tests
Related PRs
#3540
#3481