Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Axioms to users #3556

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Added Axioms to users #3556

merged 6 commits into from
Oct 9, 2020

Conversation

abhishektiwari
Copy link
Contributor

Added Axioms to users (users.js)

Added Axioms to users
@facebook-github-bot
Copy link
Contributor

Hi @abhishektiwari!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7c185ca

https://deploy-preview-3556--docusaurus-2.netlify.app

@abhishektiwari
Copy link
Contributor Author

Signed Facebook CLA.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 8, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM, just add the image/svg to our repo instead of a remote url

},
{
caption: 'Axioms',
image: 'https://static.axioms.io/branding/favicon.svg',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid future broken images we ask to add the image directly in the repo.

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhishektiwari you are using v2 so you need to add your project to the proper file - https://github.com/facebook/docusaurus/blob/master/website/src/data/users.js (because now you have added it to showcase for v1).

You will also need to upload a preview.

@slorber
Copy link
Collaborator

slorber commented Oct 8, 2020

Ah good catch :) though it was a v1 site due to no dark mode toggle presence

@abhishektiwari
Copy link
Contributor Author

@slorber @lex111 thanks. I will raise an updated pull request.

website/src/data/users.js Outdated Show resolved Hide resolved
website/src/data/users.js Outdated Show resolved Hide resolved
@slorber slorber merged commit 9c961a6 into facebook:master Oct 9, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants