-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Axioms to users #3556
Added Axioms to users #3556
Conversation
Added Axioms to users
Hi @abhishektiwari! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for docusaurus-2 ready! Built with commit 7c185ca |
Signed Facebook CLA. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM, just add the image/svg to our repo instead of a remote url
website-1.x/data/users.js
Outdated
}, | ||
{ | ||
caption: 'Axioms', | ||
image: 'https://static.axioms.io/branding/favicon.svg', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid future broken images we ask to add the image directly in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abhishektiwari you are using v2 so you need to add your project to the proper file - https://github.com/facebook/docusaurus/blob/master/website/src/data/users.js (because now you have added it to showcase for v1).
You will also need to upload a preview.
Ah good catch :) though it was a v1 site due to no dark mode toggle presence |
Added Axioms to users (users.js)