feat(v2): prevent using remote image urls in showcase #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
commented
Oct 8, 2020
| `User image should be self-hosted in /img/users folder. This was not the case for ${user.image}`, | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
seen this check just after, but does not. look like the appropriate place to do it.
|
Deploy preview for docusaurus-2 failed. Built with commit d320339 https://app.netlify.com/sites/docusaurus-2/deploys/5f7f0fab98c3b3000967c3c2 |
|
Deploy preview for docusaurus-2 ready! Built with commit 4c5f220 |
lex111
reviewed
Oct 8, 2020
website/src/data/users.js
Outdated
| if ( | ||
| !user.preview || | ||
| user.preview.startsWith('http') || | ||
| user.preview.startsWith('//') |
There was a problem hiding this comment.
CI fails because of this condition:
4:20:00 PM: TypeError: user.preview.startsWith is not a function
4:20:00 PM: at Array.forEach (<anonymous>)
4:20:00 PM: (undefined) TypeError: user.preview.startsWith is not a function
4:20:00 PM: at module.exports.users.forEach.user (main:35114:6781)
4:20:00 PM: at Array.forEach (<anonymous>)
4:20:00 PM: at Module.<anonymous> (main:35114:6735)
4:20:00 PM: at __webpack_require__ (main:21:30)
4:20:00 PM: at Promise.resolve.then (main:13011:7767)
slorber
added
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure we never accept a remote url as showcase image on Docusaurus sites, as remote URLs are likely to break over time.
(example: #3556 (review))