-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add support for RTL direction #4140
Conversation
[V1] Deploy preview success Built with commit 0e647a4 |
Size Change: +19 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built with commit 0e647a4 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4140--docusaurus-2.netlify.app/classic/ |
Oh that's cool, will try to test that soon! Thanks for working on this We should rather add this direction to the https://v2.docusaurus.io/docs/next/docusaurus.config.js#i18n |
Ah, yes, really makes sense, done. |
1a4b34c
to
b140ef2
Compare
b140ef2
to
58c2494
Compare
We also do not forget to make RTL styles for the built-in Docusaurus components. For achieve this, I suggest using the PostCSS plugin, which will be added via a new hook (see #4185). |
Thanks @lex111 that looks good to merge! Will test it soon on datagit.ir in https://github.com/massoudmaboudi/datagit_v2.docusaurus/pull/2 |
Motivation
Do not merge this PR util facebookincubator/infima#61 is approved.
Adding support for the
dir
tag is mainly to allow RTL direction.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Not ready yet.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)