Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RTL support #61

Merged
merged 1 commit into from
Feb 8, 2021
Merged

feat: add RTL support #61

merged 1 commit into from
Feb 8, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 1, 2021

Adding generation of CSS bundle with styles for RTL direction. Thus, in Docusaurus core we will dynamically include the proper file (default.css or default-rtl.css), depending on the direction specified in the config file.

Of course, we can put CSS rulesets for RTL in one same default CSS file, but this will increase this file size, so it makes more sense to generate a separate bundle for this purpose.

image

@lex111 lex111 requested a review from slorber February 1, 2021 09:25
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 1, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 8, 2021

LGTM, let's try this! The

@slorber slorber merged commit 5bf8815 into master Feb 8, 2021
@lex111
Copy link
Contributor Author

lex111 commented Feb 8, 2021

But what about merging this PR? #62

@lex111 lex111 deleted the lex111/rtl-support branch February 8, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants