Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(team): update active docusaurus team member #9893

Merged
merged 3 commits into from
Mar 6, 2024
Merged

docs(team): update active docusaurus team member #9893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffe657e
docs(team): update active docusaurus team member
OzakIOne Feb 26, 2024
2ca82d8
refactor: apply lint autofix
OzakIOne Feb 26, 2024
49cbeaa
Update website/src/components/TeamProfileCards/index.tsx
OzakIOne Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions project-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Codespaces
commonmark
contravariance
corejs
Couriol
creativecommons
Csapo
Csvg
Expand Down
54 changes: 31 additions & 23 deletions website/src/components/TeamProfileCards/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,23 +81,6 @@ function TeamProfileCardCol(props: ProfileProps) {
export function ActiveTeamRow(): JSX.Element {
return (
<div className="row">
<TeamProfileCardCol
name="Alexey Pyltsyn"
githubUrl="https://github.com/lex111">
<Translate id="team.profile.Alexey Pyltsyn.body">
Obsessed open-source enthusiast 👋 Eternal amateur at everything 🤷‍♂️
Maintainer of Russian docs on PHP, React, Kubernetes and much more 🧐
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Joel Marcey"
githubUrl="https://github.com/JoelMarcey"
twitterUrl="https://twitter.com/joelmarcey">
<Translate id="team.profile.Joel Marcey.body">
Docusaurus founder and now ever grateful Docusaurus cheerleader to
those who actually write code for it.
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Sébastien Lorber"
githubUrl="https://github.com/slorber"
Expand All @@ -123,13 +106,11 @@ export function ActiveTeamRow(): JSX.Element {
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Yangshun Tay"
githubUrl="https://github.com/yangshun"
twitterUrl="https://twitter.com/yangshunz">
name="Clément Couriol"
githubUrl="https://github.com/ozakione">
<Translate id="team.profile.Yangshun Tay.body">
Full Front End Stack developer who likes working on the Jamstack.
Working on Docusaurus made him Facebook&apos;s unofficial part-time
Open Source webmaster, which is an awesome role to be in.
Student from CPE Lyon, France. Passionate web developer who tries to
become an expert web developer.
</Translate>
</TeamProfileCardCol>
</div>
Expand All @@ -139,6 +120,33 @@ export function ActiveTeamRow(): JSX.Element {
export function HonoraryAlumniTeamRow(): JSX.Element {
return (
<div className="row">
<TeamProfileCardCol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't make this change in this PR because I'm not sure how to refactor it and present things correctly.

But it doesn't feel right to present Joel (creator of Docusaurus v1, former director of Meta OSS and now Rust foundation) as a former student 😅

I'll handle this myself later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorber "Alumni" refers to any former team member; it's not necessarily a student.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok didn't know 🤪

so we can keep it this way then 👍

name="Joel Marcey"
githubUrl="https://github.com/JoelMarcey"
twitterUrl="https://twitter.com/joelmarcey">
<Translate id="team.profile.Joel Marcey.body">
Docusaurus founder and now ever grateful Docusaurus cheerleader to
those who actually write code for it.
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Alexey Pyltsyn"
githubUrl="https://github.com/lex111">
<Translate id="team.profile.Alexey Pyltsyn.body">
Obsessed open-source enthusiast 👋 Eternal amateur at everything 🤷‍♂️
Maintainer of Russian docs on PHP, React, Kubernetes and much more 🧐
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Yangshun Tay"
githubUrl="https://github.com/yangshun"
twitterUrl="https://twitter.com/yangshunz">
<Translate id="team.profile.Yangshun Tay.body">
Full Front End Stack developer who likes working on the Jamstack.
Working on Docusaurus made him Facebook&apos;s unofficial part-time
Open Source webmaster, which is an awesome role to be in.
</Translate>
</TeamProfileCardCol>
<TeamProfileCardCol
name="Endilie Yacop Sucipto"
githubUrl="https://github.com/endiliey"
Expand Down
Loading