docs(team): update active docusaurus team member #9893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
slorber
requested changes
Mar 5, 2024
| @@ -139,6 +120,33 @@ export function ActiveTeamRow(): JSX.Element { | |||
| export function HonoraryAlumniTeamRow(): JSX.Element { | |||
| return ( | |||
| <div className="row"> | |||
| <TeamProfileCardCol | |||
There was a problem hiding this comment.
Maybe don't make this change in this PR because I'm not sure how to refactor it and present things correctly.
But it doesn't feel right to present Joel (creator of Docusaurus v1, former director of Meta OSS and now Rust foundation) as a former student 😅
I'll handle this myself later
There was a problem hiding this comment.
@slorber "Alumni" refers to any former team member; it's not necessarily a student.
There was a problem hiding this comment.
ah ok didn't know 🤪
so we can keep it this way then 👍
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
slorber
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add new active members and move unactive member to honorary alumni team
Test Plan
Build & preview
Test links
Deploy preview: https://deploy-preview-9893--docusaurus-2.netlify.app/community/team
Related issues/PRs