Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): update wrong translate id #9946

Merged
merged 1 commit into from
Mar 14, 2024
Merged

docs(website): update wrong translate id #9946

merged 1 commit into from
Mar 14, 2024

Conversation

OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Mar 12, 2024

Motivation

Wrong description on the production site

I don't know how translation id works, maybe its related to crowdin and not directly in source code ?

Test Plan

Deploy doesn't seem to be useful with the translate so I don't know

Test links

Deploy preview: https://deploy-preview-9946--docusaurus-2.netlify.app/community/team

Related issues/PRs

#9893 deploy correctly shows the description but once deployed its replaced

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 12, 2024
@OzakIOne OzakIOne changed the title fix: translate id docs(team): update wrong translate id Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

[V2]

Name Link
🔨 Latest commit 2a3aacc
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65f0db9dc6d0e100082cd8c5
😎 Deploy Preview https://deploy-preview-9946--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 69 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Mar 14, 2024
@slorber
Copy link
Collaborator

slorber commented Mar 14, 2024

Thanks

Yes we don't translate on deploy previews to keep preview deployments fasts

@slorber slorber changed the title docs(team): update wrong translate id docs(website): update wrong translate id Mar 14, 2024
@slorber slorber merged commit 6151a41 into main Mar 14, 2024
13 checks passed
@slorber slorber deleted the ozaki/fixTeam branch March 14, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants