Mac universal builds

[colinbendell]

Summary

New M1 Mac's must use rosetta to use Flipper. The Electron builder only produces x86_64 builds and the PortForwardingApp is precompiled and committed in the code base with an x64 build. This PR adds universal building of the electron app and the PortForwardingMacApp

Addresses: #3073, #2169, #2193, #2898

Changelog

Enable universal mac (mac/x64) builds

Test Plan

• yarn build --mac to build the application as per usual
• run the flipper.app as usual
• verify that app is working and that on an m1, the Kind is Apple

[colinbendell]

Placing the PortFrowarding project at the root level is messy. I only placed it there because the src is split between /PortForwardingMacApp/main.m and /ios/FlipperKit/FKPortForwarding/*.

Q: should we just refactor this and place the project and relevant sources under /desktop?

[colinbendell]

Decided to refactor anyway. PR now moves /ios/FlipperKit/FKPortForwarding/FKPortForwardingClient.* to /desktop/PortForwardingMacApp

[coveralls]

Pull Request Test Coverage Report for Build 1528623973

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 14 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.004%) to 48.257%

---

Files with Coverage Reduction	New Missed Lines	%
desktop/flipper-server-core/src/devices/ios/iOSContainerUtility.tsx	2	26.15%
desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx	2	59.42%
desktop/flipper-server-core/src/devices/ios/IOSBridge.tsx	10	68.33%

Totals
Change from base Build 1527315526:	0.004%
Covered Lines:	7423
Relevant Lines:	13974

---

💛 - Coveralls

[passy]

Thanks for putting this together, @colinbendell!

We'll probably need some time to look into this. I'm not quite sure what this means when rolling it out to M1s due the binary signing requires for which we currently have no infrastructure in place.

[colinbendell]

@passy, Why not simply use ad-hoc signed binaries? This is the approach that homebrew uses instead of signing binaries.

I've confirmed that with xcode 13 and the latest electron-builder that the resulting binaries are already ad-hoc signed when a valid Identity is not found or when CSC_IDENTITY_AUTO_DISCOVERY=false. Using this as-is would be sufficient for the time being.

[marko-asplund]

Any news on publishing universal builds?

[ZComwiz]

Let's not leave Mac Catalyst behind: #3117

[colinbendell]

Let's not leave Mac Catalyst behind: #3117

what's the intersection with this PR and Mac Catalyst?

[aarongrider]

Let me know if I can help at all with getting this over the line. Looks like the build might need some attention.

[umangloria]

Still waiting for this PR to get merged :(

[lockieluke]

please hurry up react native devs apple silicon machines were released two years ago

[cristiandan]

i guess this is just as good as #3553