feat: add tvOS support #1529
Closed
feat: add tvOS support #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Oct 6, 2024
- Test exact changes submitted in facebook/hermes#1529
|
RNTester CI build seems to be working fine: https://github.com/react-native-tvos/react-native-tvos/releases/tag/v0.76.0-0test2 |
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Oct 6, 2024
- Test exact changes submitted in facebook/hermes#1529
- Align with earlier PR to add VisionOS test (facebook#1528)
cipolleschi
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
@douglowder thankss for looking into this and for opening this PR.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Summary: Original Author: douglowder@mac.com Original Git: 924f1d1 Original Reviewed By: tmikov Original Revision: D64030986 Add Apple TV support for Hermes. *Note:* This support requires a few source file changes to work around code that will not compile for tvOS. Comments containing the compiler errors have been added. Pull Request resolved: #1529 Reviewed By: neildhar Differential Revision: D64362592 fbshipit-source-id: 6c3a698b1d87ac444869f232963a9323e8b1a05f
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 16, 2024
Summary: Adds tvOS to the list of Apple platforms supported by the Hermes artifacts. After this, the React Native TV builds will be able to use the same Hermes artifacts as those used by RN core. ~Added some code in `hermes-utils.rb` so that the Hermes podspec can use a local Maven repo (`/tmp/maven-local`).~ > *Note:* ~This PR should not be merged until the corresponding Hermes PR facebook/hermes#1529 is merged.~ (facebook/hermes#1529 has been merged) ## Changelog: [iOS][Added] tvOS support for Hermes artifacts Pull Request resolved: #46865 Test Plan: - tvOS is also added to the build and test GitHub workflows. Reviewed By: rshest Differential Revision: D64461324 Pulled By: cipolleschi fbshipit-source-id: d63889c60c72519818e7076cd0ab5851791715a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Apple TV support for Hermes.
Note: This support requires a few source file changes to work around code that will not compile for tvOS. Comments containing the compiler errors have been added.
Test Plan