feat: Add tvOS support to Hermes artifacts #46865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
douglowder
force-pushed
the
hermes-tvos
branch
from
f67cc95 to
d9773eb
Compare
cipolleschi
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Hi @douglowder, thanks for the PR. I believe we should drop the maven_local changes as there is nothing related to iOS there.
packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh
Outdated
Show resolved
Hide resolved
cipolleschi
requested changes
Oct 10, 2024
douglowder
commented
Oct 10, 2024
douglowder
force-pushed
the
hermes-tvos
branch
from
8df3a7b to
00fbbff
Compare
douglowder
force-pushed
the
hermes-tvos
branch
from
00fbbff to
8f1a3d5
Compare
cipolleschi
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks @douglowder for working on this and for integrating tvOS in the Hermes pipeline. This will reduce the OSS fragmentation.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in f673759. |
|
This pull request was successfully merged by @douglowder in f673759 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Summary: After examining Hermes artifacts built after merging of #46865 , it was apparent that tvOS frameworks were missing from the Hermes universal framework generated by CI. I went back and discovered additional steps that need to be added to the `build-hermes-macos` action to make CI work correctly. ## Changelog: [Internal][Fixed] add required steps to build tvOS in build-hermes-macos action Pull Request resolved: #47073 Test Plan: After merging, Hermes artifacts generated by CI should contain the missing tvOS bits. Reviewed By: rshest Differential Revision: D64528911 Pulled By: cipolleschi fbshipit-source-id: 61db3e154767830a4726d7ceeec229a4af30d247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds tvOS to the list of Apple platforms supported by the Hermes artifacts. After this, the React Native TV builds will be able to use the same Hermes artifacts as those used by RN core.
Added some code inhermes-utils.rbso that the Hermes podspec can use a local Maven repo (/tmp/maven-local).Changelog:
[iOS][Added] tvOS support for Hermes artifacts
Test Plan: