Skip to content

Commit

Permalink
Disable benchmark tests
Browse files Browse the repository at this point in the history
Summary: MPMCQueue intermixes tests and benchmarks. The benchmarks, since they take a long time, are flakey. Disable them.

Reviewed By: Orvid

Differential Revision: D40069957

fbshipit-source-id: 91786209a6f2ff446c0f3531aa50c2e0656cf3ad
  • Loading branch information
Gownta authored and facebook-github-bot committed Oct 5, 2022
1 parent ffa90fe commit e7ff4b4
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions third-party/folly/src/folly/test/MPMCQueueTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -591,11 +591,13 @@ void runMtProdConsDeterministicDynamic(
}
}

TEST(MPMCQueue, mt_prod_cons_deterministic) {
// This is a benchmark, not a test
TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic) {
runMtProdConsDeterministic(0);
}

TEST(MPMCQueue, mt_prod_cons_deterministic_dynamic) {
// This is a benchmark, not a test
TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic_dynamic) {
runMtProdConsDeterministic<true>(0);
}

Expand All @@ -607,7 +609,8 @@ void setFromEnv(T& var, const char* envvar) {
}
}

TEST(MPMCQueue, mt_prod_cons_deterministic_dynamic_with_arguments) {
// This is a benchmark, not a test
TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic_dynamic_with_arguments) {
long seed = 0;
uint32_t prods = 10;
uint32_t cons = 10;
Expand Down Expand Up @@ -656,11 +659,13 @@ void runMtProdCons() {
}
}

TEST(MPMCQueue, mt_prod_cons) {
// This is a benchmark, not a test
TEST(MPMCQueue, DISABLED_mt_prod_cons) {
runMtProdCons();
}

TEST(MPMCQueue, mt_prod_cons_dynamic) {
// This is a benchmark, not a test
TEST(MPMCQueue, DISABLED_mt_prod_cons_dynamic) {
runMtProdCons</* Dynamic = */ true>();
}

Expand Down

0 comments on commit e7ff4b4

Please sign in to comment.