Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use resolve package in jest-resolve #9520

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 5, 2020

Summary

Ref #2925 (comment) (and #9505).

This keeps the optimizations from #8388 by passing the cached isFile and isDirectory to resolve. We can also implement readFile backed by HasteFS (like #2925 talks about) in the future.

Test plan

Green CI. I've kept all of our tests, so hopefully we're sufficiently covered

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #9520 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9520      +/-   ##
==========================================
- Coverage   65.03%   65.02%   -0.02%     
==========================================
  Files         283      283              
  Lines       12158    12114      -44     
  Branches     3014     3000      -14     
==========================================
- Hits         7907     7877      -30     
+ Misses       3608     3598      -10     
+ Partials      643      639       -4
Impacted Files Coverage Δ
packages/jest-resolve/src/defaultResolver.ts 68.96% <57.14%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ae594...553a333. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants