-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use resolve
package in jest-resolve
#9520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #9520 +/- ##
==========================================
- Coverage 65.03% 65.02% -0.02%
==========================================
Files 283 283
Lines 12158 12114 -44
Branches 3014 3000 -14
==========================================
- Hits 7907 7877 -30
+ Misses 3608 3598 -10
+ Partials 643 639 -4
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Ref #2925 (comment) (and #9505).
This keeps the optimizations from #8388 by passing the cached
isFile
andisDirectory
toresolve
. We can also implementreadFile
backed by HasteFS (like #2925 talks about) in the future.Test plan
Green CI. I've kept all of our tests, so hopefully we're sufficiently covered