fix(jest-resolve): disable jest-pnp-resolver for Yarn 2
#10847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jeysal
approved these changes
Nov 19, 2020
|
Yay! 🎉 The PnP integration test fails on CI, tho. Also, can you remove https://github.com/facebook/jest/blob/a66eec74b55dc98ab072be330c13c54c35cba5f7/packages/jest-resolve/src/defaultResolver.ts#L26-L33? |
merceyz
force-pushed
the
merceyz/pnp-fix
branch
from
9570734
to
af03f02
Compare
merceyz
changed the title
jest-pnp-resolver for Yarn 2
merceyz
force-pushed
the
merceyz/pnp-fix
branch
from
af03f02
to
f0c5178
Compare
|
I can't actually remove the plugin as that would be a breaking change for Yarn 1 PnP users, so instead I disabled it for Yarn 2. I updated the test and it passes locally so lets hope the CI agrees |
|
👍 We could consider dropping v1 support in a future major |
SimenB
reviewed
Nov 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #9520
jest-resolvewas switched to useresolvewhich, because Yarn 2 patches it, supports PnP. This makesjest-pnp-resolverunnecessary but it can't be removed as that would be a breaking change for Yarn 1 PnP users but it can be disabled for Yarn 2.Main reason for doing this is that
jest-pnp-resolverdoesn't support projects where there are multiplepnpapiinstances but the patch inresolvedoes.Test plan
Tests should still pass