Fix printing #29
Merged
Fix printing #29
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Seems like Travis is unhappy with the timeout, as always? I originally followed @voideanvalue's suggestion that this should not be in recast, but given that it already seems to handle this it makes a lot of sense. |
|
Not again... I will just set the timeout to a minute :P |
There have been multiple reports about the printed source missing trailing line breaks. The reason for the line break missing is that this information is contained in the `File` node, which is returned by `recast.parse`. However, because we build a node collection from the `Program` node instead of the `File` node, we are loosing this information. Using the `File` node fixes the issue and doesn't seem to break any existing functionality.
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
Improve readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple reports about the printed source missing trailing line breaks. The reason for the line break missing is that this information is contained in the
Filenode, which is returned byrecast.parse.However, because we build a node collection from the
Programnode instead of theFilenode, we are loosing this information.Using the
Filenode fixes the issue and doesn't seem to break any existing functionality.