Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command logging into tree view #4022

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Add command logging into tree view #4022

merged 1 commit into from
Mar 3, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Mar 3, 2023 •
edited
Loading

Add logs for commands in dispatch order to the TreeView plugin.

Screenshot 2023-03-03 at 13 36 47

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2023
@vercel
Copy link

vercel bot commented Mar 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 1:46PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 1:46PM (UTC)

@thegreatercurve thegreatercurve marked this pull request as ready for review March 3, 2023 13:38
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.13 KB (0%) 523 ms (0%) 403 ms (+22.35% 🔺) 926 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.92 KB (0%) 739 ms (0%) 399 ms (+70.79% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 36.9 KB (0%) 738 ms (0%) 378 ms (-42.92% 🔽) 1.2 s

@thegreatercurve thegreatercurve mentioned this pull request Mar 3, 2023
Merged
zurfyx
zurfyx approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but we should add a way to toggle what you need, otherwise the TreeView will become impossible to follow as we keep adding more and more features (one of the things I find the most interesting about the TreeView is the ability to follow the internals as I'm writing code - both of them visible)

@thegreatercurve thegreatercurve merged commit ea82cb5 into main Mar 3, 2023
@fantactuka
Copy link
Contributor

fantactuka commented Mar 3, 2023 •
edited
Loading

This might not handle plugin commands properly (in case plugin rendered after tree view).

@acywatson acywatson mentioned this pull request Mar 8, 2023
Merged
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the feat/command-logging-in-tree-view branch July 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thegreatercurve @fantactuka @zurfyx @facebook-github-bot