Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate experimental DevTools browser extension #4023

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Mar 3, 2023

Our recent strategy for providing developer tooling was to support the ASCII TreeView component whilst simultaneously building the developer tools web extension.

However, despite some great work done by Meta interns on the web extension, we've found that as a team, we have little time to devote to polish and productionize the experimental code; the developer tools web extension would offer few new features; and for internal purposes, the TreeView component has been more than sufficient to help Meta teams debug Lexical editor state issues.

With that in mind, I think it's best to deprecate the developer tools web extension and just concentrate on further improvements to the TreeView component. It already supports most of the high-priority features we initially looked to support in the web extension (now that command logging has been added as well #4022).

Closes #2127

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2023
@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Mar 3, 2023 at 1:50PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Mar 3, 2023 at 1:50PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.13 KB (0%) 523 ms (0%) 112 ms (+64.4% 🔺) 635 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.92 KB (0%) 739 ms (0%) 93 ms (-6.42% 🔽) 831 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.9 KB (0%) 738 ms (0%) 62 ms (-39.73% 🔽) 800 ms

@thegreatercurve thegreatercurve merged commit 89985f7 into main Mar 3, 2023
@thegreatercurve thegreatercurve deleted the feat/remove-dev-tools branch March 3, 2023 15:56
@acywatson acywatson mentioned this pull request Mar 8, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Developer Tools Web Extension
3 participants