feat: use dev/prod conditions instead of webpack in exports #5858
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| */ | ||
| 'use strict'; | ||
| const glob = require('glob'); | ||
| const path = require('node:path'); | ||
| const fs = require('fs-extra'); | ||
|
|
||
| const alias = Object.fromEntries( | ||
| glob('./packages/*/package.json', {sync: true}).flatMap((fn) => { | ||
| const pkg = fs.readJsonSync(fn); | ||
| if (!pkg.private) { | ||
| return Object.entries(pkg.exports).flatMap(([k, v]) => { | ||
| if (k.endsWith('.js')) { | ||
| return []; | ||
| } | ||
| return [ | ||
| [ | ||
| `${pkg.name}${k.replace(/^\.(\/$)?/, '')}`, | ||
| path.resolve(path.dirname(fn), 'dist', v.require.default), | ||
| ], | ||
| ]; | ||
| }); | ||
| } | ||
| return []; | ||
| }), | ||
| ); | ||
|
|
||
| const extendConfig = {resolve: {alias}}; | ||
| const modifyWebpackConfig = (config) => Object.assign(config, extendConfig); | ||
|
|
||
| function sizeLimitConfig(pkg) { | ||
| return { | ||
| path: alias[pkg], | ||
| modifyWebpackConfig, | ||
| }; | ||
| } | ||
|
|
||
| module.exports = ['lexical', '@lexical/rich-text', '@lexical/plain-text'].map( | ||
|
There was a problem hiding this comment. Why only these 3 packages? Can we discover them based on the config property in their dirs/package.json? We already do glob here There was a problem hiding this comment. I think that would be an @fantactuka question (size-limit was introduced in #3600), these were the only modules measured in the previous configuration. Now that we do have more infrastructure to support this size-limit tool we have more options but the measurements are only useful if people care about them and I don't know what the team cares about especially because there is no configured limits such that the build would fail. |
||
| sizeLimitConfig, | ||
| ); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add comment that explains purpose of this file.
Also can you pls elaborate on why we replace simple config from
package.jsonwith this fairly complex file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never really worked correctly, outside of the main lexical package anyway, so that's one reason! :)
When checking the size of @lexical/rich-text or @lexical/plain-text it would have to pull in whatever lexical package was in node_modules (plus their other monorepo dependencies like @lexical/clipboard), which would be some previously published version.
The other reason is that it simply didn't work with the simpler configuration. I don't know why or when it stopped working, but that was the primary motivation. I only discovered it was often wrong even in the best of times when I investigated further.