Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MyRocks loses data after clean shudown, if WAL is disabled #127

Closed
yoshinorim opened this issue Dec 23, 2015 · 1 comment
Closed

MyRocks loses data after clean shudown, if WAL is disabled #127

yoshinorim opened this issue Dec 23, 2015 · 1 comment

Comments

@yoshinorim
Copy link
Contributor

I'm writing a test case for load-optimized config -- https://gist.github.com/yoshinorim/57edc6533143a99c768f -- it fails if setting rocksdb_write_disable_wal=1. After clean shutdown and restart, some committed data is lost. If setting rocksdb_write_disable_wal=0 (default), not data is lost.
yoshinorim added a commit that referenced this issue Dec 23, 2015
@yoshinorim
MyRocks: Flush memtables on clean shutdown (#127)
f25469b 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Test Plan: new test case rocksdb.insert_optimized_config

Reviewers: spetrunia, jkedgar, hermanlee4

Reviewed By: hermanlee4

Subscribers: sdong, rven, webscalesql-eng

Differential Revision: https://reviews.facebook.net/D52257
@yoshinorim
Copy link
Contributor Author

https://reviews.facebook.net/D52257

yoshinorim added a commit that referenced this issue Jan 5, 2016
@yoshinorim @jtolmer
MyRocks: Flush memtables on clean shutdown (#127)
9375a2a 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Test Plan: new test case rocksdb.insert_optimized_config

Reviewers: spetrunia, jkedgar, hermanlee4

Reviewed By: hermanlee4

Subscribers: sdong, rven, webscalesql-eng

Differential Revision: https://reviews.facebook.net/D52257
@mariadb-DanielLee mariadb-DanielLee mentioned this issue Mar 17, 2016
Closed
hermanlee pushed a commit that referenced this issue Jan 31, 2017
@yoshinorim
MyRocks: Flush memtables on clean shutdown (#127)
efcbdbc 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Test Plan: new test case rocksdb.insert_optimized_config

Reviewers: spetrunia, jkedgar, hermanlee4

Reviewed By: hermanlee4

Subscribers: sdong, rven, webscalesql-eng

Differential Revision: https://reviews.facebook.net/D52257
VitaliyLi pushed a commit to VitaliyLi/mysql-5.6 that referenced this issue Feb 9, 2017
@yoshinorim @jkedgar
MyRocks: Flush memtables on clean shutdown (facebook#127)
0f8f5f2 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Test Plan: new test case rocksdb.insert_optimized_config

Reviewers: spetrunia, jkedgar, hermanlee4

Reviewed By: hermanlee4

Subscribers: sdong, rven, webscalesql-eng

Differential Revision: https://reviews.facebook.net/D52257
facebook-github-bot pushed a commit that referenced this issue Dec 23, 2019
@yoshinorim @facebook-github-bot
MyRocks: Flush memtables on clean shutdown (#127)
1c31380 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 12, 2020
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
26bb8cb 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 9, 2020
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
9138356 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 16, 2020
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
a78714f 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Oct 5, 2020
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
0abde77 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Nov 11, 2020
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
9122f02 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 04b83d1
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Mar 11, 2021
@yoshinorim @facebook-github-bot
MyRocks: Flush memtables on clean shutdown (facebook#127)
d45778c 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 16, 2021
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
6933231 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 30, 2021
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
82c3727 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 30, 2021
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
2cd6bd6 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 1, 2021
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
9e354df 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 2, 2021
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
de5eb85 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257

fbshipit-source-id: 1c87c632249
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jan 17, 2022
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
a4ed750 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Apr 26, 2022
@yoshinorim
MyRocks: Flush memtables on clean shutdown (facebook#127)
06eb4dd 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 20, 2022
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
109b223 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
laurynas-biveinis pushed a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 11, 2022
@yoshinorim
MyRocks: Flush memtables on clean shutdown (facebook#127)
3bd491b 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Mar 28, 2023
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
cd2b6a0 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 1, 2023
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
36198ad 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 14, 2023
@yoshinorim @inikep
MyRocks: Flush memtables on clean shutdown (facebook#127)
1504231 
Summary:
On clean shutdown, memtables were not flushed. This caused
data loss, if WAL was disabled. This diff flushes all
memtables before calling CancelAllBackgroundWork().

Differential Revision: https://reviews.facebook.net/D52257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yoshinorim