Compiling the MyRocks project failed #207
Comments
|
Can you please follow the steps at https://github.com/facebook/mysql-5.6/wiki/Reporting-bugs-and-asking-for-help and add the relevant information about the OS which is being used, toolset version etc. This way we can do something actionable to investigate the issue. |
|
myrocks@rocksdb:~/builds/mytest/log$ uname -a myrocks@rocksdb:~/builds/mytest/log$ lsb_release -a Commands used to make the project: echo These commands were extracted from a .sh script. They were working fine last week. |
|
What is the version of the toolset you're using and what is it (Clang, GCC)? For example: |
|
myrocks@rocksdb: myrocks@rocksdb: |
|
Thank you for detailed information, gcc 4.8.x doesn't implement a support for Good way to fix this issue is to update the compiler toolset to at least gcc 4.9.2. Most likely this won't be the first or last change which will rely on the enhanced error detection in the newer versions of GCC. |
|
Quick alternative is also to remove all the four instances of HTH |
…ith gcc 4.8.x again Summary: The issue was exposed by #207. The root cause is the fact that gcc 4.8.x doesn't implement a support for `returns_nonnull`. Take a look at https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html vs. https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Function-Attributes.html. For last couple of months we've been operating under the assumption that gcc 4.9.x is the lowest supported platform. We need to go back and internally either revisit this decision or be very explicit about our dependency requirements. Test Plan: Optimistic fix, needs to be really verified on the system running gcc 4.8.x. ``` mysqlbuild.sh ``` Reviewers: yoshinorim, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55641
|
Attributes breaking build with gcc 4.8.x removed. Please try |
|
myrocks@rocksdb:~/builds/reptest/mysql-5.6$ git show Compiled successfully after upgrading gcc to 4.9.3 |
|
Thank you for validating! |
…ith gcc 4.8.x again Summary: The issue was exposed by facebook/mysql-5.6#207. The root cause is the fact that gcc 4.8.x doesn't implement a support for `returns_nonnull`. Take a look at https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html vs. https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Function-Attributes.html. For last couple of months we've been operating under the assumption that gcc 4.9.x is the lowest supported platform. We need to go back and internally either revisit this decision or be very explicit about our dependency requirements. Test Plan: Optimistic fix, needs to be really verified on the system running gcc 4.8.x. ``` mysqlbuild.sh ``` Reviewers: yoshinorim, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55641
…ith gcc 4.8.x again Summary: The issue was exposed by facebook/mysql-5.6#207. The root cause is the fact that gcc 4.8.x doesn't implement a support for `returns_nonnull`. Take a look at https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html vs. https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Function-Attributes.html. For last couple of months we've been operating under the assumption that gcc 4.9.x is the lowest supported platform. We need to go back and internally either revisit this decision or be very explicit about our dependency requirements. Test Plan: Optimistic fix, needs to be really verified on the system running gcc 4.8.x. ``` mysqlbuild.sh ``` Reviewers: yoshinorim, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55641
…ith gcc 4.8.x again Summary: The issue was exposed by facebook#207. The root cause is the fact that gcc 4.8.x doesn't implement a support for `returns_nonnull`. Take a look at https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html vs. https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Function-Attributes.html. For last couple of months we've been operating under the assumption that gcc 4.9.x is the lowest supported platform. We need to go back and internally either revisit this decision or be very explicit about our dependency requirements. Test Plan: Optimistic fix, needs to be really verified on the system running gcc 4.8.x. ``` mysqlbuild.sh ``` Reviewers: yoshinorim, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55641
myrocks@rocksdb:~/builds/mytest/mysql-5.6$ git show
commit d3054d2
end of the make command output
.
.
.
.
1043 [ 57%] Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/unireg.cc.o
1044 [ 57%] Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/sql_timer.cc.o
1045 Linking CXX static library libsql_embedded.a
1046 [ 57%] Built target sql_embedded
1047 make: *** [all] Error 2
myrocks@rocksdb:~/builds/mytest/log$ cat -n 5.make.log |grep error
27 [ 2%] [ 2%] Building C object regex/CMakeFiles/regex.dir/regerror.c.o
109 Building C object mysys/CMakeFiles/mysys.dir/errors.c.o
153 Building C object mysys/CMakeFiles/mysys.dir/my_error.c.o
308 [ 14%] Generating ../include/mysqld_error.h, ../sql/share/english/errmsg.sys
538 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb.h:599:40: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
544 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:49:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
547 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:53:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
550 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:57:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
567 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb.h:599:40: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
575 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:49:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
578 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:53:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
581 /home/myrocks/builds/mytest/mysql-5.6/storage/rocksdb/./ha_rocksdb_proto.h:57:62: error: ‘returns_nonnull’ attribute directive ignored [-Werror=attributes]
599 [ 28%] cc1plus: all warnings being treated as errors
616 cc1plus: all warnings being treated as errors
806 [ 41%] Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/error_stats.cc.o
816 [ 41%] Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/derror.cc.o
950 [ 50%] Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/sql_alloc_error_handler.cc.o
994 Building CXX object libmysqld/CMakeFiles/sql_embedded.dir//sql/sql_error.cc.o
The text was updated successfully, but these errors were encountered: