Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engine restriction #31

Closed

Conversation

jacob-israel-turner
Copy link

Hello!

I'm working with an older React Native application, attempting to upgrade it to more recent versions. I have upgraded Node to v14. I ran into issues with ViewPropTypes when upgrading React Native to 0.69, so I installed this package. Unfortunately the engine requirement here creates a bit of a burden when installing. As far as I can tell, the project works fine on Node 14.

Is there any reason the engine constraint can't be removed?

Thanks!

@GijsWeterings
Copy link

Node 18 is the oldest version of node still receiving security support, see https://endoflife.date/nodejs. Node versions older than that are explicitly not supported because they impose significant security risk to applications. I highly recommend upgrading your Node version to 18 or higher.

@cipolleschi
Copy link

On top of what @GijsWeterings said, React Native 0.69 is not supported anymore. We strongly encourage to migrate to a more recent version of the framework, possibly 0.72 because 0.73 will be out soon and when that happens, we will drop support for 0.70.

@jacob-israel-turner
Copy link
Author

Huh, didn't realize v14 was out of LTS already. Thanks for taking a look.

@robhogan
Copy link
Contributor

robhogan commented Nov 16, 2023

Prop-types depends on @react-native/normalize-color, which has a minimum Node version according to its RN version. V5 depends on RN 0.73 and therefore Node 18.

You can continue to use v4 or v3 with older RN versions, they have no engine restriction (and should also be a closer match to the actual prop types of those versions).

See #27 for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants