[prop-types] v5.0.0. Use semver range dependencies, drop Node <18. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhogan
force-pushed
the
feat/prop-types-v5
branch
from
f484244
to
ca9476d
Compare
robhogan
force-pushed
the
feat/prop-types-v5
branch
from
d713556
to
ab707f9
Compare
huntie
approved these changes
Oct 12, 2023
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 14, 2023
Summary: To address the root cause of a recurring issue (#40797, #39692) where breaking changes to `react-native/normalize-colors` would be pulled into old versions of `deprecated-react-native-prop-types`, we recently change the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869). For CI, we generally force `react-native/*` to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently `0.74.1`) isn't semver-compatible with `deprecated-react-native-prop-types`'s dependency (`^0.73.0`), so `npm install` was failing in CI with "no package found". We should be getting `0.73.2` from the public registry in this case. This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more. ## Changelog: [INTERNAL] [FIXED] - CI/Verdaccio: Proxy `react-native/normalize-colors` from NPM for the `deprecated-react-native-prop-types` dependency. Pull Request resolved: #40971 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D50298291 Pulled By: robhogan fbshipit-source-id: 4bf6503108335ffa52654346d1874c217071ff91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old releases of React Native pin to a
react-native-deprecated-prop-typesversion that in turn depends on"@react-native/normalize-colors": *.This is problematic, because it means breaking changes to RN/NC are automatically pulled in to old RN projects. This has come up twice when we've tried to introduce a Node >=18 requirement to RN/NC, in
0.73.1and0.74.0(facebook/react-native#39692, facebook/react-native#40797).Let's put a stop to this by capping the prop-types V4 branch at
<0.73.0, and releasing a v5.0.0 which:"node": ">=18"requirement explicitly mirroring the one in RN."@react-native/normalize-colors": "^0.73.0". We'll be free to expand this to"^0.73.0 || ^0.74.0", etc, as we confirm compatibility.